优化

lastleg-service/src/test/java/com/baiyue/lastleg/masterdata/vehicle/adapter/in/web/PlatformVehicleControllerContractTest.java

@@ -1,4 +1,4 @@
-package com.baiyue.lastleg.masterdata.vehicle.controller;
+package com.baiyue.lastleg.masterdata.vehicle.adapter.in.web;
 
 import org.junit.jupiter.api.Test;
 import org.springframework.security.access.prepost.PreAuthorize;

lastleg-service/src/test/java/com/baiyue/lastleg/masterdata/vehicle/application/VehicleApplicationServiceTest.java

@@ -0,0 +1,64 @@
+package com.baiyue.lastleg.masterdata.vehicle.application;
+
+import com.baiyue.lastleg.masterdata.vehicle.application.VehicleApplicationService.FailureKind;
+import com.baiyue.lastleg.masterdata.vehicle.application.VehicleApplicationService.VehicleFailure;
+import com.baiyue.lastleg.masterdata.vehicle.application.model.VehicleModels;
+import com.baiyue.lastleg.masterdata.vehicle.application.port.out.VehicleRepository;
+import com.baiyue.lastleg.masterdata.vehicle.application.port.out.VehicleRepository.VehicleSnapshot;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.math.BigDecimal;
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class VehicleApplicationServiceTest {
+    private VehicleRepository repository;
+    private VehicleApplicationService service;
+
+    @BeforeEach
+    void setUp() {
+        repository = mock(VehicleRepository.class);
+        service = new VehicleApplicationService(repository);
+    }
+
+    @Test
+    void rejectsStaleVersionBeforeUpdating() {
+        when(repository.lockById(1L)).thenReturn(Optional.of(vehicle(3L, 1000L)));
+        VehicleModels.Update request = update(2L, 1000L);
+        assertThatThrownBy(() -> service.update(1L, "9", request))
+            .isInstanceOfSatisfying(VehicleFailure.class,
+                failure -> assertThat(failure.kind()).isEqualTo(FailureKind.CONFLICT));
+    }
+
+    @Test
+    void rejectsDecreasingOdometer() {
+        when(repository.lockById(1L)).thenReturn(Optional.of(vehicle(3L, 1000L)));
+        VehicleModels.Update request = update(3L, 999L);
+        assertThatThrownBy(() -> service.update(1L, "9", request))
+            .isInstanceOfSatisfying(VehicleFailure.class,
+                failure -> assertThat(failure.kind()).isEqualTo(FailureKind.BAD_REQUEST));
+    }
+
+    @Test
+    void rejectsUnknownStatus() {
+        when(repository.lockById(1L)).thenReturn(Optional.of(vehicle(3L, 1000L)));
+        assertThatThrownBy(() -> service.changeStatus(1L, "9", new VehicleModels.ChangeStatus("BUSY", 3L)))
+            .isInstanceOfSatisfying(VehicleFailure.class,
+                failure -> assertThat(failure.kind()).isEqualTo(FailureKind.BAD_REQUEST));
+    }
+
+    private static VehicleModels.Update update(long version, long mileage) {
+        return new VehicleModels.Update(version, "ABC-001", "Box Truck", new BigDecimal("12.50"), mileage,
+            "Driver", "123", "OVERSEAS", "OWNED", null);
+    }
+
+    private static VehicleSnapshot vehicle(long version, long mileage) {
+        return new VehicleSnapshot(1L, "ABC-001", "Box Truck", new BigDecimal("12.50"), mileage,
+            "Driver", "123", "OVERSEAS", "OWNED", "IN_SERVICE", null, version, "9", null);
+    }
+}

lastleg-service/src/test/java/com/baiyue/lastleg/masterdata/vehicle/service/VehicleServiceTest.java

@@ -1,63 +0,0 @@
-package com.baiyue.lastleg.masterdata.vehicle.service;
-
-import com.baiyue.lastleg.masterdata.vehicle.dto.VehicleDtos;
-import com.baiyue.lastleg.masterdata.vehicle.entity.Vehicle;
-import com.baiyue.lastleg.masterdata.vehicle.mapper.VehicleMapper;
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
-import org.springframework.test.util.ReflectionTestUtils;
-import org.springframework.web.server.ResponseStatusException;
-
-import java.math.BigDecimal;
-
-import static org.assertj.core.api.Assertions.assertThatThrownBy;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
-class VehicleServiceTest {
-    private VehicleMapper mapper;
-    private VehicleService service;
-
-    @BeforeEach
-    void setUp() {
-        mapper = mock(VehicleMapper.class);
-        service = new VehicleService();
-        ReflectionTestUtils.setField(service, "vehicles", mapper);
-    }
-
-    @Test
-    void rejectsStaleVersionBeforeUpdating() {
-        when(mapper.lockById(1L)).thenReturn(vehicle(3L, 1000L));
-        VehicleDtos.Update request = update(2L, 1000L);
-        assertThatThrownBy(() -> service.update(1L, "9", request))
-            .isInstanceOf(ResponseStatusException.class)
-            .hasMessageContaining("409 CONFLICT");
-    }
-
-    @Test
-    void rejectsDecreasingOdometer() {
-        when(mapper.lockById(1L)).thenReturn(vehicle(3L, 1000L));
-        VehicleDtos.Update request = update(3L, 999L);
-        assertThatThrownBy(() -> service.update(1L, "9", request))
-            .isInstanceOf(ResponseStatusException.class)
-            .hasMessageContaining("400 BAD_REQUEST");
-    }
-
-    @Test
-    void rejectsUnknownStatus() {
-        when(mapper.lockById(1L)).thenReturn(vehicle(3L, 1000L));
-        assertThatThrownBy(() -> service.changeStatus(1L, "9", new VehicleDtos.ChangeStatus("BUSY", 3L)))
-            .isInstanceOf(ResponseStatusException.class)
-            .hasMessageContaining("400 BAD_REQUEST");
-    }
-
-    private static VehicleDtos.Update update(long version, long mileage) {
-        return new VehicleDtos.Update(version, "ABC-001", "Box Truck", new BigDecimal("12.50"), mileage,
-            "Driver", "123", "OVERSEAS", "OWNED", null);
-    }
-
-    private static Vehicle vehicle(long version, long mileage) {
-        Vehicle value = new Vehicle(); value.setId(1L); value.setRecordVersion(version); value.setMileageKm(mileage);
-        value.setStatus("IN_SERVICE"); return value;
-    }
-}