优化

lastleg-service/src/test/java/com/baiyue/lastleg/MapperRegistrationArchitectureTest.java

@@ -0,0 +1,30 @@
+package com.baiyue.lastleg;
+
+import com.tngtech.archunit.core.domain.JavaClasses;
+import com.tngtech.archunit.core.importer.ClassFileImporter;
+import org.apache.ibatis.annotations.Mapper;
+import org.junit.jupiter.api.Test;
+import org.mybatis.spring.annotation.MapperScan;
+
+import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.classes;
+import static org.assertj.core.api.Assertions.assertThat;
+
+class MapperRegistrationArchitectureTest {
+    private static final JavaClasses PRODUCTION_CLASSES = new ClassFileImporter()
+        .importPackages("com.baiyue.lastleg");
+
+    @Test
+    void everyMapperInterfaceDeclaresItsRegistrationMarker() {
+        classes().that().areInterfaces().and().haveSimpleNameEndingWith("Mapper")
+            .should().beAnnotatedWith(Mapper.class)
+            .because("Mapper registration must fail during tests instead of service startup")
+            .check(PRODUCTION_CLASSES);
+    }
+
+    @Test
+    void applicationUsesOneAnnotationFilteredRootScan() {
+        MapperScan scan = BaiyueLastlegApplication.class.getAnnotation(MapperScan.class);
+        assertThat(scan.basePackages()).containsExactly("com.baiyue.lastleg");
+        assertThat(scan.annotationClass()).isEqualTo(Mapper.class);
+    }
+}

lastleg-service/src/test/java/com/baiyue/lastleg/masterdata/MasterDataMapperConfigurationTest.java

@@ -1,25 +0,0 @@
-package com.baiyue.lastleg.masterdata;
-
-import org.apache.ibatis.annotations.Mapper;
-import org.junit.jupiter.api.Test;
-import org.mybatis.spring.annotation.MapperScan;
-
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThatThrownBy;
-
-class MasterDataMapperConfigurationTest {
-    @Test
-    void scansOnlyAnnotatedMasterDataMappers() {
-        MapperScan mapperScan = MasterDataMapperConfiguration.class.getAnnotation(MapperScan.class);
-
-        assertThat(mapperScan.basePackages()).containsExactly("com.baiyue.lastleg.masterdata");
-        assertThat(mapperScan.annotationClass()).isEqualTo(Mapper.class);
-    }
-
-    @Test
-    void broadExchangeMapperScanMustNotBeReintroduced() {
-        assertThatThrownBy(() -> Class.forName(
-            "com.baiyue.lastleg.masterdata.exchange.ExchangeMapperConfiguration"))
-            .isInstanceOf(ClassNotFoundException.class);
-    }
-}

lastleg-service/src/test/java/com/baiyue/lastleg/pda/PdaOperationsMapperConfigurationTest.java

@@ -1,20 +0,0 @@
-package com.baiyue.lastleg.pda;
-
-import org.junit.jupiter.api.Test;
-import org.mybatis.spring.annotation.MapperScan;
-
-import static org.assertj.core.api.Assertions.assertThat;
-
-class PdaOperationsMapperConfigurationTest {
-    @Test
-    void scansEveryPdaWarehouseOperationMapperPackage() {
-        MapperScan mapperScan = PdaOperationsMapperConfiguration.class.getAnnotation(MapperScan.class);
-
-        assertThat(mapperScan.basePackages()).containsExactlyInAnyOrder(
-                "com.baiyue.lastleg.palletops.mapper",
-                "com.baiyue.lastleg.pda.move.mapper",
-                "com.baiyue.lastleg.pda.stocktake.mapper",
-                "com.baiyue.lastleg.pda.warehouse.mapper"
-        );
-    }
-}

lastleg-service/src/test/java/com/baiyue/lastleg/shipping/ShippingMapperConfigurationTest.java

@@ -1,15 +0,0 @@
-package com.baiyue.lastleg.shipping;
-
-import org.junit.jupiter.api.Test;
-import org.mybatis.spring.annotation.MapperScan;
-
-import static org.assertj.core.api.Assertions.assertThat;
-
-class ShippingMapperConfigurationTest {
-    @Test
-    void scansShippingMappers() {
-        MapperScan mapperScan = ShippingMapperConfiguration.class.getAnnotation(MapperScan.class);
-
-        assertThat(mapperScan.basePackages()).containsExactly("com.baiyue.lastleg.shipping.mapper");
-    }
-}