优化
This commit is contained in:
+12
-6
@@ -5,8 +5,7 @@ import com.baiyue.lastleg.dispatch.controller.DispatchController;
|
||||
import com.baiyue.lastleg.dispatch.controller.DispatchQueryController;
|
||||
import com.baiyue.lastleg.dispatch.controller.SmartDispatchController;
|
||||
import com.baiyue.lastleg.dispatch.pda.controller.DispatchPdaController;
|
||||
import com.baiyue.lastleg.inboundplan.pda.controller.InboundPalletAssignmentController;
|
||||
import com.baiyue.lastleg.inboundplan.pda.controller.InboundPdaController;
|
||||
import com.baiyue.lastleg.inboundplan.pda.controller.ReceivingContainerController;
|
||||
import com.baiyue.lastleg.inventory.command.controller.InventoryCommandController;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
|
||||
@@ -26,10 +25,17 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
|
||||
|
||||
class Phase4BrowserApiBoundaryTest {
|
||||
@Test
|
||||
void inboundPdaAndUnloadPhotoApisUseThePdaAccessDomain() {
|
||||
assertTrue(basePath(InboundPdaController.class).startsWith("/api/pda/v1/"));
|
||||
assertTrue(basePath(InboundPalletAssignmentController.class).startsWith("/api/pda/v1/"));
|
||||
assertFalse(basePath(InboundPdaController.class).contains("/api/platform/"));
|
||||
void onlyStableContainerReceivingUsesThePdaInboundAccessDomain() throws Exception {
|
||||
assertTrue(basePath(ReceivingContainerController.class).startsWith("/api/pda/v1/"));
|
||||
assertFalse(basePath(ReceivingContainerController.class).contains("/api/platform/"));
|
||||
Path controllers = Path.of("src/main/java/com/baiyue/lastleg/inboundplan/pda/controller");
|
||||
String source = Files.walk(controllers).filter(path -> path.toString().endsWith(".java"))
|
||||
.map(path -> {
|
||||
try { return Files.readString(path); }
|
||||
catch (Exception exception) { throw new IllegalStateException(exception); }
|
||||
}).collect(Collectors.joining("\n"));
|
||||
assertFalse(source.contains("/api/pda/v1/last-leg/inbound-plans/{planNo}"));
|
||||
assertFalse(source.contains("@RequestParam(required = false) String customerId"));
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
-42
@@ -1,42 +0,0 @@
|
||||
package com.baiyue.lastleg.inboundplan.pda.controller;
|
||||
|
||||
import com.baiyue.common.security.AuthenticatedUser;
|
||||
import com.baiyue.lastleg.inboundplan.pda.dto.PdaRequests;
|
||||
import com.baiyue.lastleg.inboundplan.pda.service.InboundPdaWorkflowService;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.springframework.test.util.ReflectionTestUtils;
|
||||
import org.springframework.web.server.ResponseStatusException;
|
||||
|
||||
import java.util.Set;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.assertThrows;
|
||||
import static org.mockito.Mockito.mock;
|
||||
import static org.mockito.Mockito.verify;
|
||||
|
||||
class InboundPalletAssignmentControllerTest {
|
||||
private final InboundPdaWorkflowService service = mock(InboundPdaWorkflowService.class);
|
||||
private final InboundPalletAssignmentController controller = controller();
|
||||
private final PdaRequests.Assign request = new PdaRequests.Assign(1L, 2L, 3L, "assign-key");
|
||||
|
||||
@Test
|
||||
void assignmentRequiresPdaOperatePermissionAndExplicitPlatformCustomer() {
|
||||
assertThrows(ResponseStatusException.class,
|
||||
() -> controller.assign(user(Set.of()), "PLAN-1", 4L, "100", request));
|
||||
assertThrows(ResponseStatusException.class,
|
||||
() -> controller.assign(user(Set.of(InboundPdaController.OPERATE_PERMISSION)), "PLAN-1", 4L, null, request));
|
||||
|
||||
controller.assign(user(Set.of(InboundPdaController.OPERATE_PERMISSION)), "PLAN-1", 4L, "100", request);
|
||||
|
||||
verify(service).assign("100", "PLAN-1", 4L, request);
|
||||
}
|
||||
|
||||
private AuthenticatedUser user(Set<String> permissions) {
|
||||
return new AuthenticatedUser(7L, 0L, 0L, 8L, "operator", "PLATFORM", "PDA", permissions);
|
||||
}
|
||||
|
||||
private InboundPalletAssignmentController controller() {
|
||||
InboundPalletAssignmentController value = new InboundPalletAssignmentController();
|
||||
ReflectionTestUtils.setField(value, "service", service);
|
||||
return value;
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user