优化

firstleg/src/main/java/com/baiyue/firstleg/terminaldrayage/service/TerminalDrayageMailDispatcher.java

@@ -20,11 +20,10 @@ public class TerminalDrayageMailDispatcher {
     @Value("${baiyue.terminal-drayage.mail.port:587}") private int port;
     @Value("${baiyue.terminal-drayage.mail.username}") private String username;
     @Value("${baiyue.terminal-drayage.mail.password}") private String password;
-    @Value("${baiyue.terminal-drayage.mail.from}") private String from;
     @Value("${baiyue.terminal-drayage.mail.ssl:false}") private boolean ssl;
 
     JavaMailSenderImpl sender() {
-        TerminalDrayageMailService.validateAddress(from);
+        TerminalDrayageMailService.validateAddress(username);
         var sender = new JavaMailSenderImpl();
         sender.setHost(host); sender.setPort(port); sender.setUsername(username); sender.setPassword(password);
         sender.setDefaultEncoding("UTF-8");
@@ -47,7 +46,7 @@ public class TerminalDrayageMailDispatcher {
             if (mapper.claimMail(mail.id()) != 1) continue;
             try {
                 var message = new SimpleMailMessage();
-                message.setFrom(from); message.setTo(mail.recipient());
+                message.setFrom(username); message.setTo(mail.recipient());
                 message.setSubject(mail.subject()); message.setText(mail.body());
                 sender().send(message);
                 if (mapper.completeMail(mail.id()) != 1) log.warn("Terminal drayage mail completion requires review: {}", mail.id());

firstleg/src/main/java/com/baiyue/firstleg/terminaldrayage/service/TerminalDrayageMailService.java

@@ -34,11 +34,12 @@ public class TerminalDrayageMailService {
 
     public void replaceFleet(long containerId, String containerNo, long oldSupplierId, long newSupplierId, long operatorId) {
         var next = contact(newSupplierId, true);
-        // 取消通知发往原请求的收件地址；尚未发过请求则读取原车队资料，允许原车队已停用。
+        // 请求邮件记录就是当前车队是否已下发的事实；未下发过时不能向原车队发送无来源的取消通知。
         MailTask previous = mapper.lastPickupMail(containerId, oldSupplierId);
-        var old = previous == null ? contact(oldSupplierId, false)
-            : new WarehouseSupplierClient.TruckingContact(oldSupplierId, previous.fleetName(), previous.recipient());
-        enqueue(containerId, containerNo, oldSupplierId, old.name(), old.email(), "CANCEL_PICKUP", operatorId);
+        if (previous != null) {
+            enqueue(containerId, containerNo, oldSupplierId, previous.fleetName(), previous.recipient(),
+                "CANCEL_PICKUP", operatorId);
+        }
         enqueue(containerId, containerNo, newSupplierId, next.name(), next.email(), "REQUEST_PICKUP", operatorId);
     }