fix: return A0404 for missing PDA pallets

2026-09-04 14:07:18 +08:00
parent f6247ce232
commit 3399ae7488
13 changed files with 205 additions and 7 deletions
@@ -111,14 +111,26 @@ public class HttpWarehouseResourceGateway implements WarehouseResourceGateway {
            .uri("/internal/v1/warehouse-pallets/resolve/{palletCode}", palletCode)
            .header("X-Internal-Service-Token", internalToken)
            .retrieve().onStatus(HttpStatusCode::isError, (request, result) -> {
-                throw new IllegalArgumentException("Warehouse rejected pallet code: HTTP " + result.getStatusCode());
+                throw palletLookupFailure(result.getStatusCode());
            }).body(WarehousePalletResponse.class);
-        if (response == null || response.data() == null) throw new IllegalArgumentException("Warehouse returned an empty pallet response");
+        if (response != null && "A0404".equals(response.code())) {
+            throw new ResponseStatusException(HttpStatus.NOT_FOUND, "Warehouse pallet was not found");
+        }
+        if (response == null || response.data() == null) {
+            throw new ResponseStatusException(HttpStatus.SERVICE_UNAVAILABLE,
+                "Warehouse pallet service returned no usable response");
+        }
        return new WarehousePalletReference(response.data().id(), response.data().palletCode(),
            response.data().warehouseId(), response.data().locationId(), response.data().status(),
            response.data().fbaWarehouseCode(), response.data().version());
    }

+    private ResponseStatusException palletLookupFailure(HttpStatusCode status) {
+        return new ResponseStatusException(status.value() == 404 ? HttpStatus.NOT_FOUND
+            : (status.is4xxClientError() ? HttpStatus.BAD_REQUEST : HttpStatus.SERVICE_UNAVAILABLE),
+            status.value() == 404 ? "Warehouse pallet was not found" : "Warehouse pallet lookup failed");
+    }
+
    @Override
    public WarehouseLocationReference resolveLocation(long warehouseId, String locationCode) {
        WarehouseLocationResponse response = client.get()
@@ -173,7 +185,7 @@ public class HttpWarehouseResourceGateway implements WarehouseResourceGateway {
        return response.data();
    }

-    private record WarehousePalletResponse(WarehousePalletData data) {}
+    private record WarehousePalletResponse(String code, String message, WarehousePalletData data) {}
    private record WarehousePalletData(@JsonAlias("palletId") long id, String palletCode, long warehouseId, long locationId,
                                       String status, String fbaWarehouseCode, int version) {}
    private record ReserveEnvelope(ReserveData data) {}